Unable to get property 'query' of undefined or null reference

XMLWordPrintable

      problem

      If the iframe is not ready in Editor.plugins.VisualReview.controller.SegmentMapping::getSegmentDom, it can come to the following JS error:
      "Unable to get property 'query' of undefined or null reference" in line 381!

      If the extFrame is falsy the whole function should return also false.

      aleksandar please fix, but with minimal effort so that this may not cause future complications with other functionality in the code (see below discussion)

      Exception details:

      Stack:
      getSegmentDom @ SegmentMapping.js:381:13
      updateReviewLayoutSingle @ SegmentMapping.js:338:13
      onSegmentInfoRecordUpdated @ SegmentMapping.js:178:9
      fire @ ext-all-debug.js:20731:21
      dispatch @ ext-all-debug.js:57952:33
      prototype.doFireEvent @ ext-all-debug.js:58109:17
      fireEventArgs @ ext-all-debug.js:21553:17
      fireEvent @ ext-all-debug.js:21512:13
      updateRecord @ SegmentInfo.js:82:7
      updateRecordInStore @ SegmentMapping.js:188:9

       

      Browser / Device:

      Browser: Microsoft Edge 16.16299 
      OS: Windows 10
      Window size: 1536 x 747
      Device pixel ratio: 1.25
      UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36 Edge/16.16299
      Touch:  
      Language: de-DE
      Installed Plugins:
      • Edge PDF Viewer Portable Document Format

      Application:

      Environment:  
      Version identifier: development
      Framework: ExtJS 620
       

      This happening after switchting the view:

       user.click #editorViewport #visualReviewActionButtons #taskActionButtons #switchEditorModeBtn => .x-btn-icon-el

            Assignee:
            Aleksandar Mitrev
            Reporter:
            Thomas Lauria
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: