Uploaded image for project: 'translate5'
  1. translate5
  2. TRANSLATE-4421

Quick insert sdlxliff tags do not get incremented short tag number

Details

    • High
    • SDLXLIFF Import: Fix tag duplicating issue for segments with Quick insert tags

    Description

      Problem

      If in sdlxliff we getting quick insert tag id in target code will assign this tag with short tag starting from 1.
      That leads to error in front end on attempt to save segment. User will get duplicating tag error.
      But in fact that number may be already in use by some general g tag like `<g id="47">`

      So as we start short numbers for target segment from new counter that leads to error of short number assigning.

      For now we found this issue only with quick insert tags but judging from code we may encounter exact same problem if for some unknown reason file will have new numerical id in target segment.

      Solution

      Consider that tag ids in target segment may be different from source and so short numbers should be generated with increment following from source to target.

      Attachments

        Activity

          [TRANSLATE-4421] Quick insert sdlxliff tags do not get incremented short tag number
          aleksandar Aleksandar Mitrev made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Releasable [ 10901 ] New: Done [ 10000 ]
          aleksandar Aleksandar Mitrev made changes -
          Fix Version/s New: translate5 - 7.20.3 [ 14512 ]
          aleksandar Aleksandar Mitrev made changes -
          Status Original: Final pull request [ 10005 ] New: Releasable [ 10901 ]
          sanya@mittagqi.com Sanya Mikhliaiev made changes -
          Status Original: In Progress [ 3 ] New: Final pull request [ 10005 ]
          sanya@mittagqi.com Sanya Mikhliaiev made changes -
          Status Original: Final pull request [ 10005 ] New: In Progress [ 3 ]
          sanya@mittagqi.com Sanya Mikhliaiev made changes -
          Status Original: In Progress [ 3 ] New: Final pull request [ 10005 ]
          sanya@mittagqi.com Sanya Mikhliaiev made changes -
          ChangeLog Description New: SDLXLIFF Import: Fix tag duplicating issue for segments with Quick insert tags
          sanya@mittagqi.com Sanya Mikhliaiev made changes -
          Assignee Original: Thomas Lauria [ tlauria ] New: Sanya Mikhliaiev [ sanya@mittagqi.com ]
          sanya@mittagqi.com Sanya Mikhliaiev made changes -
          Status Original: Selected for dev [ 10100 ] New: In Progress [ 3 ]
          sanya@mittagqi.com Sanya Mikhliaiev made changes -
          Status Original: Open [ 10002 ] New: Selected for dev [ 10100 ]

          People

            sanya@mittagqi.com Sanya Mikhliaiev
            sanya@mittagqi.com Sanya Mikhliaiev
            Aleksandar Mitrev
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: