Details
-
Task
-
Resolution: Fixed
-
None
-
None
-
None
-
Empty show more show less
Description
problem
It happens sometimes that JS code is published which is either invalid or hard to understand or does have other problems. Mainly ES6 shorthand method definition which is not allowed in IE11.
solution
To prevent this jslint could be used to check the JS code before release (or even before commit on each machine, or nightly on master.translate5.net).
Installation of jslint is easy, just install nodejs, then do:
sudo npm install -g jshint
After that the projectfiles can be checked with:
jshint public/modules/ application/modules/
Which currently gives 251 errors in Plugin and core JS code.
Most of the stuff can be fixed easily, also is jslint configurable, so we can configure what should be threatened as error and what not.
Attachments
Issue Links
- relates to
-
TRANSLATE-1243 IE11 could not load Segment.js
- Done
-
TRANSLATE-1448 translate5 stops loading with Internet Explorer 11
- Done