Uploaded image for project: 'translate5'
  1. translate5
  2. TRANSLATE-1991

Repetition editor does not work in some cases

    • Icon: Bug Bug
    • Resolution: Unresolved
    • None
    • None
    • Repetition editor

      On marc.translate5.net in the task "ZEIT ONLINE" the segment Nr. 16 produces an error when saving it and trying to also save its repetition. Happens when logged in as Manager, who is assigned as second reviewer.

      See attached screenshot

          [TRANSLATE-1991] Repetition editor does not work in some cases

          marcmittag After looking deeper this is a more bigger problem:

          • The Project was imported with existing terms in TC: "time" and "online".
          • Therefore the segment 16 "time online" was term tagged accordingly (time and online each tagged).
          • Then in the TC the term "time" was deleted or "moved" to a new term DB entry with a new id due term merging (here it is unclear if this can happen or if the old term remains).
          • In the segment there is still the term "time" marked up with the DB ID stored internally in the tag (for the markTransFound recalculation).
          • If the segment itself is opened and saved
            • without modification: the term markup remains as it is and the repetition editor comes up (see below)
            • with modification: the segment is term tagged again, therefore the term time is not marked any more since it seems to be deleted in the TC
          • In both cases the repetition editor comes up. For repetitions we never did a retagging since the source part, did not change, and the term tags of the target could be recycled, only the transfound recalculation was triggered.
            Now comes the problem: in the source the term "time" is still marked, containing the ID of the now deleted term. With this not anymore existing ID the recalculation is tried to be done, a internal not found is triggered which then fires the error in repetition editing.

          That leads to two possible solutions:

          1. refactor the change alike handling, so that each repeated segment is now also newly tagged (correct but slower and more effort)
          2. just remove the terms in the repeated source where the id is not valid anymore (should be easily possible). But: new terms added to the TC in the meantime are not found in the source of such a segment.

          Thomas Lauria added a comment - marcmittag After looking deeper this is a more bigger problem: The Project was imported with existing terms in TC: "time" and "online". Therefore the segment 16 "time online" was term tagged accordingly (time and online each tagged). Then in the TC the term "time" was deleted or "moved" to a new term DB entry with a new id due term merging (here it is unclear if this can happen or if the old term remains). In the segment there is still the term "time" marked up with the DB ID stored internally in the tag (for the markTransFound recalculation). If the segment itself is opened and saved without modification: the term markup remains as it is and the repetition editor comes up (see below) with modification: the segment is term tagged again, therefore the term time is not marked any more since it seems to be deleted in the TC In both cases the repetition editor comes up. For repetitions we never did a retagging since the source part, did not change, and the term tags of the target could be recycled, only the transfound recalculation was triggered. Now comes the problem: in the source the term "time" is still marked, containing the ID of the now deleted term. With this not anymore existing ID the recalculation is tried to be done, a internal not found is triggered which then fires the error in repetition editing. That leads to two possible solutions: refactor the change alike handling, so that each repeated segment is now also newly tagged (correct but slower and more effort) just remove the terms in the repeated source where the id is not valid anymore (should be easily possible). But: new terms added to the TC in the meantime are not found in the source of such a segment.

          tlauria: To answer your question I must understand more, where the error is coming from. Because what I would expect translate5 to do here is simply to adjust the repeated segment to what I have changed in the current segment (content and processing status). For me it is absolut unclear, what this has to do with a may be corrupt TC. So what I would expect here, if the reason is a corrupt TC, that the repetion editor works as it should and we get an error somewhere regarding the corrupt TC.

          Marc Mittag [Administrator] added a comment - - edited tlauria : To answer your question I must understand more, where the error is coming from. Because what I would expect translate5 to do here is simply to adjust the repeated segment to what I have changed in the current segment (content and processing status). For me it is absolut unclear, what this has to do with a may be corrupt TC. So what I would expect here, if the reason is a corrupt TC, that the repetion editor works as it should and we get an error somewhere regarding the corrupt TC.

          Hi marcmittag, what for a fix do you expect here?

          The reason is coming from the term collection,  so I assume that the term collection is defect here.

          What do you expect for the fix?

          • Was the term collection newly created? So do we have a new bug in the term import?
          • Or was it an old TC? Should I recreate your term collection then?
          • Should the user should never get such a message? (what would be wrong here, since there was an error)

          What I will do: I will wrap the error with an appropriate translate5 error message.

           

          Thomas Lauria added a comment - Hi marcmittag , what for a fix do you expect here? The reason is coming from the term collection,  so I assume that the term collection is defect here. What do you expect for the fix? Was the term collection newly created? So do we have a new bug in the term import? Or was it an old TC? Should I recreate your term collection then? Should the user should never get such a message? (what would be wrong here, since there was an error) What I will do: I will wrap the error with an appropriate translate5 error message.  

            tlauria Thomas Lauria
            marcmittag Marc Mittag [Administrator]
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: