problem

Some parts of Search and Replace are not stateful yet: 

Search Button

"If I put something in the search field and close the search box and open it again the text remains there (what is what we want). Yet the search button is not active, first I need to type something. This must be changed. If something is in the search field, the search button must always be active."

Problem here: the validator function which is responsible also for setting the active state of the button is called multiple times. So the button active state flaps and remains in the end deactivated. The question is, why is the validation called multiple times on multiple values. It seems to be invoked per field instead per form.

Search Field

In the replace tab the content is not saved in the search field. This seems to come from a magic function which syncs the content between searchtab and replace tab.

Closing window

When closing the window with X the state is saved. When closing the window with the close button, the state is not saved.

In both cases a state save is triggered after opening the window again, what is also strange.

active tab

The last active tab should also be stateful (except the user uses ctrl-F or ctrl-H which should open the wanted tab. Same when using the search over the menu: if it was on the replace tab, and the user uses the menu from a non editable content column, then the searchtab should be opened instead the replace tab).

solution

Currently the whole logic controlling which tab should be activated on window open is very complicated.

A refactoring of the search and replace window is needed to achieve the above stateful needs and making changes in the future easier.

See also TRANSLATE-2217.