Uploaded image for project: 'translate5'
  1. translate5
  2. TRANSLATE-2548

Reenable commenting of non editable segments

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • None
    • None
    • Editor general

    Description

      problem

      • There is a feature enabling segment commenting for read only segments, controlled via ACL
      • This feature is not working any more as expected (it is just not working)

      solution

      1. Move the control if the feature is enabled or not from ACL (editorCommentsForLockedSegments)to a task level config
      2. The old implementation was a quirks implementation regarding how comments could be edited / added in the segment meta panel, since the segment meta panel is disabled in non editable segments.
        Due that quirks implementation the comments panel at the right works only sometimes for non editable segments.
        Therefore this part is changed by using the comment pop-up as it is used in the visual review simple mode. So if a segment is not editable for the user, then the comments are edited in the popup instead of the partly disabled segment meta panel.
        This implies that the comment pop-up code is moved from visual review plug-in to core code
      3. Expected behaviour regarding definition of read-only:
        1. If a task is opened read-only then no commenting should be allowed too
        2. If a task is read-only due the workflow (status waiting / finished) then commenting should be allowed on read-only segments (if enabled via config)
          1. If this case should enable or disable commenting should be moved to a config on job level (not part of this issue since job level does currently not exist)
        3. In the viewport view-model is distinguished between the above two different read-only modes

      Attachments

        Issue Links

          Activity

            People

              tlauria Thomas Lauria
              tlauria Thomas Lauria
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated: