Uploaded image for project: 'translate5'
  1. translate5
  2. TRANSLATE-3414

sdlxliff comments produce several problems

    XMLWordPrintable

Details

    • Medium
    • Fix problem where sdlxliff comment are not correctly processed on import and export.

    Description

      Deletion of sdlxliff comments produces problems

      translate5 because of legacy reasons with unknown reason deletes all comments of an sdlxliff file on import of the file.

      The reason may have been, that translate5 also exports translate5 comments into sdlxliff als sdlxliff comments and the deletion of existing comments ensures, that nothing interfers.

      Yet now there seems to be a change in sdlxliff format.

      In the header of the sdlxliff file there is a probably new section like this

       

      <cmt-meta-defs><cmt-meta-def id="beaebf3d-8ad6-4cb3-b9f6-e47fdd943736"><cmt-meta-data id="0"><value key="NoteWithoutPriority">True</value></cmt-meta-data></cmt-meta-def><cmt-meta-def id="71d9a6ee-050b-4ed9-b5c0-0e57e85ac3aa"><cmt-meta-data id="0"><value key="NoteWithoutPriority">True</value></cmt-meta-data></cmt-meta-def>...

      that is not deleted by translate5.

      Also in the transunit there is also a tag referencing the comment, that is also not deleted like this:

      <sdl:cmt id="beaebf3d-8ad6-4cb3-b9f6-e47fdd943736"/></trans-unit>

       

      So this must be repaired, so that sdlxliff comments again work with the latest version of Trados Studio.

      To delete existing comments is bad practice.

      This should be changed so, that new comments, that are created in translate5 are simply added to the existing Studio comments instead of deleting the existing ones and adding only the new ones.

      BTW: the comment section in the header of an sdlxliff file, that contains the actual comments, that are then referenced in the transunit looks like this:

      <cmt-defs><cmt-def id="beaebf3d-8ad6-4cb3-b9f6-e47fdd943736"><Comments><Comment severity="Low" user="" date="2022-06-02T11:25:48.5234901+02:00" version="1.0">Text im Warndialog</Comment></Comments></cmt-def><cmt-def id="71d9a6ee-050b-4ed9-b5c0-0e57e85ac3aa"><Comments><Comment severity="Low" user="" date="2022-06-02T11:25:48.5234901+02:00" version="1.0">Text im Hinweisdialog</Comment></Comments></cmt-def><cmt-def id="1c532072-f01b-4072-a8ff-a66ed4138e5d"><Comments><Comment severity="Low" user="" date="2022-06-02T11:25:48.5244849+02:00" version="1.0">Text im Hinweisdialog</Comment></Comments></cmt-def> ... </cmt-defs>

      sdlxliff comment import does not work anymore

      There is an import option

      runtimeOptions.import.sdlxliff.importComments

      If active, comments from sdlxliff should be imported into translate5 as translate5 comments.

      By default this option is deactivated.

      Yet if activated, the comment import still does not work.

      It should be fixed, so that it works again.

      Also it should be ensured, that if sdlxliff comments import is active, that the sdlxliff comments are not reexported again, because they should be left untouched in the sdlxliff file. Only new comments made in translate5 should be reexported (this may work already if the import works again, but should be checked, if correctly implemented). And no one should be able to edit the sdlxliff comments in translate5 (the latter should work out of the box, because they do not belong to a translate5 user).

       

      Attachments

        Issue Links

          Activity

            People

              aleksandar Aleksandar Mitrev
              marcmittag Marc Mittag [Administrator]
              Thomas Lauria
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: