Uploaded image for project: 'translate5'
  1. translate5
  2. TRANSLATE-3461

Use http header fields only lowercase

XMLWordPrintable

    • Critical
    • FIX: evaluation of sent request headers is case-insensitive now

      problem

      When using http2 in near future, http header field names are only used in lowercase, since there will be no difference anymore in upper / lowercase. In consequence headers are delivered in lowercase to translate5 and we have to convert all access to lowercase.

      This can be already done now by converting everytime to lowercase.

      Currently we probably have the following headers on receiving requests:

      • Translate5AuthToken
      • Accept → handled by Zend internal mechanisms, here it must be evaluated if a sanitized usage is already done
      • Probably the OpenID usage

      On sending this is also the case, at least:

      • maintenance mode headers
      • translate5 version headers

      Others?

      When using Zend_Controller_Request_Http::getHeader this is done implicitly, so I assume that affects only places where we did implement that manually.

      solution

      Convert all headers to lowercase before usage, convert all internally defined header names also to lowercase.

       

       

       

            tlauria Thomas Lauria
            tlauria Thomas Lauria
            Thomas Lauria
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: