Uploaded image for project: 'translate5'
  1. translate5
  2. TRANSLATE-4405

Clean up config usage

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Unresolved
    • None
    • None
    • Configuration
    • Low
    • Code clean up surround the configuration code

      problem

      When using the internal configuration data through Zend_Config the data is properly converted out of DB by ConfigType and convertValue method.

      There are several places where config values are used raw from DB / with the loadAllMerged methods for example. On most of that usages a manual json_decode is done afterwards instead of respecting the correct ConfigType and its converter. This must be changed in order to reduce possible errors.

      See also PR https://bitbucket.org/mittagqi/translate5/pull-requests/1580 where FilterPreset.php another such usages were added.

      solution

      Improve that in general so that loadAllMerged returns the ready to be used values or similar solution.

            tlauria Thomas Lauria
            tlauria Thomas Lauria
            Thomas Lauria
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: