problem

In the Visual Approval Workflow the task is fetched by t5connect in the middle of the workflow on translate5 side, but t5connect wants to set the task to status end when fetched.

Currently this is deactivated by config in the affected installations, but that must be changed.

solution

Instead of setting the task status to end, t5connect should set the field foreignState to end (or similar name, perhaps "returned"). foreignState was added in issue TRANSLATE-4482 already.

In translate5 we have to listen for foreignState changes and execute some workflow actions, by default set the task to status end.

In the visual approve state nothing should happen instead, so that end action must be removed here in the workflow.

This was not done together with MITTAGQI-344 because a migration is missing at that point of time. Migration means: t5connect must loop over its internally stored task, which are returned to across and set for that tasks the foreignState to "returned" (as specified above) without triggering the automated actions.

h2. addition
The "foreign-fields" (foreignName, foreignId foreignName) should be selectable as fields that can be shown in Translate5 GUI. This request may is already in another issue, but can not be found any more.
Done by Thomas for user with admin role