Uploaded image for project: 'translate5'
  1. translate5
  2. TRANSLATE-4947

User approve ends in error when task is created with intial state "unconfirmed"

XMLWordPrintable

    • High
    • Unconfirmed task could not be approved.

      Problem

      to reproduce the problem you have to follow these steps:

      1. set config config runtimeOptions.import.initialTaskState to unconfirmed
      2. create a new task
      3. assign a user (reviewer)
      4. login to T5 as review-user
      5. open the task => popup "approve" will appear

      6. click on "approve" => error happens

      OPEN: And it is possible to NOT approve but finish the task. User should not be asked if he wants to finish on leaving, when not approved.

      Solution

      Fix the assertion preventing to confirm the task.

      Also prevented that the approve dialogue is shown when the user is not in proper state. For example a user with job waiting could also open the task readonly (before for example a translator did open the task and approve it) and approve it - what makes no sense. 

      Testing

      also try to add a second reviewer and check if this must approve after first reviewer has approved the task.

            tlauria Thomas Lauria
            Stephan Stephan Bergmann
            Aleksandar Mitrev
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: