Problem

Some time ago we added check for critical QA errors to "Leave task" popup.

So now when task has errors popup is not shown for editor and that is in a way misleading behaviour. It rises questions for new users and for those who only started to use Critical errors feature.

The thing is that it is not obvious for editor how to proceed in this case. And for old users it may even feel like a bug.

Solution

Likely it will be enough to change:

public/modules/editor/js/app/view/segments/grid/HeaderViewController.js:254 

Desired result is that popup shown even if task has critical QA errors.

In this case once user clicks on "Finish" he should be informed that task has errors and he can't finish it unless errors are resolved.

Test

For test one can setup "Empty translation" as critical error in task config and try to leave task with some segment not yet translated.