Details
-
Improvement
-
Resolution: Unresolved
-
None
-
None
-
High
-
Empty show more show less
Description
Some derivative classes from editor_Services_Connector_Abstract at least editor_Services_OpenTM2_Connector and its related classes like editor_Services_OpenTM2_HttpApi need to be refactored because of grown complexity. Classes have grown significantly and it becomes more and more challenging to maintain them.
What should be done:
- Split code to smaller classes
- Complete all TODOs and FIXMEs
- Change processResponse to return typed DTO instead of stdClass
- Remove public setters such as setResource and setLanguageResource etc. since they are breaking encapsulation and making it possible to have the model in an invalid state
- Change resultList to be initialized on every request instead of constructor
- Make services to be retrieved from registry and make them to be guessed by name and not by class (Original discussion here https://bitbucket.org/mittagqi/translate5/pull-requests/804)
- Clean Up Fuzzy TM stuff, currently is cluttered over multiple levels of code and is to error prone (by saving fuzzy TM name to DB in case of errors etc)
Attachments
Issue Links
- blocks
-
TRANSLATE-2217 List refactoring and code maintenance needs in translate5
- Selected for dev
- is blocked by
-
TRANSLATE-3754 Fix tag handling in taking over matches from matchresource panel
- Done
- relates to
-
TRANSLATE-3225 DeepL at times simply not answers requests leading to errors in T5 that suggest the app is malfunctioning
- Done