Improve and Update Visual Containers: 1) Headless converter

XMLWordPrintable

    • High
    • None
    • Visual Improvement: Update visualconverter (now called browserconverter) that is not based on "browserless" but a native chrome Image. This updates the headless chrome and fixes the capturing of JS errors happening during headless workloads
    • None
    • HI-120

      Problem

      • The visualconverter consumes all JavaScript errors & Exceptions that occur during headless workloads. Reason for this is the use of browserless - that also is memory-heavy due to an inbuild unused job-management. This e.g. prevents a proper development of the print-to-pdf feature for website downloads

      Solution
      The visualconverter (headless chrome) container should be based on a "normal" headless-chrome image with php & chrome-php added. We may can use this: https://github.com/Laurianti/headless-chromium-php-docker

      The visual-headlessconverter code needs to be adopted to the new image as starting & stopping chrome has to be added to the code. Then the JavaScript-errors/exceptions during visual workloads can be catched & reported back to translate5 via the log. => AXEL's task

      Frontend-Tests

      a) Prequesites
       To test the improvements the browserconverter container must be version 1.1 (can be checked with t5 service:check )
      If the tests are performed on a cloud-instance, set runtimeOptions.plugins.VisualReview.visualConverterUrl to http://t5-visual-services.web.inetsolutions.cloud:8084

      b) Tests
      The browserconverter container was adjusted for performance and shall replace the existing visualconverter.
      All visual types must work as they are working currently.

      • Test all visual-types from nextcloud/Developer/test-data/visual/testdata (not the VIDEO - which does not use the container)
      • Test all imports from nextcloud/Developer/test-data/visual/testdata-toobig: They must all be importable (takes a while)

            Assignee:
            Axel Becher
            Reporter:
            Axel Becher
            None
            None
            Thomas Lauria
            Axel Becher
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              None
              None